Skip to content

OCPEDGE-2090: Add validation tests for tnf topology effects #30252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

OCPEDGE-2090: Add validation tests for tnf topology effects #30252

merged 2 commits into from
Sep 16, 2025

Conversation

@eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Sep 12, 2025 •
edited
Loading

updated tests to always target two node topology instead of being a suite tests
small refactor and testing name change
added test to check platform type is set to baremetal or none
added test to check baremetal hosts are set to detached

@eggfoobar
upkeep: removed two node suite from regular checks
9810f24 
updated tests to always target two node topology instead of being a suite tests
small refactor and testing name change

Signed-off-by: ehila <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2025 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-2090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

updated tests to always target two node topology instead of being a suite tests
small refactor and testing name change
added test to check platform type is set to baremetal or none
added test to check etcd operator is set to external
added test to check baremetal hosts are set to detached

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ovn-two-node-fencing-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ovn-two-node-fencing-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/59b62d40-8ffb-11f0-88d3-77832bfb0434-0

@eggfoobar
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ovn-two-node-fencing-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ovn-two-node-fencing-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f232f30-8ffb-11f0-8422-eda9c7f79cd3-0

@eggfoobar
Copy link
Contributor Author

/test e2e-metal-ovn-two-node-fencing

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2025 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-2090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

updated tests to always target two node topology instead of being a suite tests
small refactor and testing name change
added test to check platform type is set to baremetal or none
added test to check baremetal hosts are set to detached

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar
Copy link
Contributor Author

/test e2e-metal-ovn-two-node-fencing

@jaypoulz
Copy link
Contributor

/approve
/lgtm

@jaypoulz
Copy link
Contributor

Reviewed in this thread: https://redhat-internal.slack.com/archives/C07ABRBBDK3/p1757696848339999

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2025
@openshift-trt
Copy link

openshift-trt bot commented Sep 12, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 378bf9b

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-metal-ovn-two-node-fencing Medium - "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have etcd pods and containers configured correctly [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-metal-ovn-two-node-fencing Medium - "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have podman etcd containers running on each node [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-metal-ovn-two-node-fencing Medium - "[sig-node][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing topology should have BareMetalHost operational status set to detached if they exist [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-metal-ovn-two-node-fencing Medium - "[sig-node][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing topology should have infrastructure platform type set correctly [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-metal-ovn-two-node-fencing Medium - "[sig-node][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing topology should only have two control plane nodes and no arbiter nodes [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 378bf9b

  • "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have etcd pods and containers configured correctly [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have podman etcd containers running on each node [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing topology should have BareMetalHost operational status set to detached if they exist [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing topology should have infrastructure platform type set correctly [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing topology should only have two control plane nodes and no arbiter nodes [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@eggfoobar
feat: add tests to validate DualReplica topology effects
f31169c 
added test to check platform type is set to baremetal or none
added test to check baremetal hosts are set to detached
fixed suite filter to capture OCPFeatureGate

Signed-off-by: ehila <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2025
@eggfoobar
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ovn-two-node-fencing-recovery-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2025

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ovn-two-node-fencing-recovery-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ad12b110-9042-11f0-89a3-31730936a01e-0

@jaypoulz
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
@sosiouxme
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, jaypoulz, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025
@sosiouxme
Copy link
Member

/verified by "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have etcd pods and containers configured correctly [Suite:openshift/conformance/parallel]" , "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have podman etcd containers running on each node [Suite:openshift/conformance/parallel]"
(and so on)

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 15, 2025
@openshift-ci-robot
Copy link

@sosiouxme: This PR has been marked as verified by "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have etcd pods and containers configured correctly [Suite:openshift/conformance/parallel]","[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have podman etcd containers running on each node [Suite:openshift/conformance/parallel]".

In response to this:

/verified by "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have etcd pods and containers configured correctly [Suite:openshift/conformance/parallel]" , "[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:DualReplica] Two Node with Fencing should have podman etcd containers running on each node [Suite:openshift/conformance/parallel]"
(and so on)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da0ca22 and 2 for PR HEAD f31169c in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da0ca22 and 2 for PR HEAD f31169c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da0ca22 and 2 for PR HEAD f31169c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD da0ca22 and 2 for PR HEAD f31169c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025 •
edited
Loading

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia f31169c link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-disruptive f31169c link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway f31169c link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/okd-scos-e2e-aws-ovn f31169c link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-kube-apiserver-rollout f31169c link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ovn-two-node-fencing 378bf9b link false /test e2e-metal-ovn-two-node-fencing
ci/prow/e2e-azure f31169c link false /test e2e-azure
ci/prow/e2e-metal-ipi-ovn-dualstack f31169c link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-hypershift-conformance f31169c link false /test e2e-hypershift-conformance
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout f31169c link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Sep 16, 2025

Job Failure Risk Analysis for sha: f31169c

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (19) are below the historical average (1644): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (19) are below the historical average (805): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (21) are below the historical average (1672): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (18) are below the historical average (1581): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 187efd4 into openshift:main Sep 16, 2025
38 of 47 checks passed
@eggfoobar eggfoobar deleted the add-tnf-check-tests branch September 16, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omertuc omertuc Awaiting requested review from omertuc

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

1 more reviewer

@jaypoulz jaypoulz jaypoulz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaypoulz jaypoulz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eggfoobar @openshift-ci-robot @jaypoulz @sosiouxme